search

sbt / sbt-osgi

sbt plugin for creating OSGi bundles
Apache License 2.0
47 stars 43 forks source link

Fix infinite recursion with Compile packageBin #105

Open mdedetrich opened 8 months ago

mdedetrich commented 8 months ago

Resolves https://github.com/sbt/sbt-osgi/issues/104

Pinging @romainreuillon since https://github.com/sbt/sbt-osgi/pull/79#issue-1884046058 was the cause of the regression. @romainreuillon Can you confirm that this PR still solves the asynchronicity issue with package task?

@eed3si9n Since you know the sbt internals if you have time maybe you can comment on this (since at https://github.com/sbt/sbt-osgi/pull/79#issuecomment-1761802032 you did mention that doing this can cause issues). See the linked issue for more info

mdedetrich commented 8 months ago

Hmm, so this PR is causing test-10-multi-project-dependsOn-includePackage-versions to fail, likely because of ordering issues will have to have a further look. In general the change in https://github.com/sbt/sbt-osgi/pull/79#issue-1884046058 looks like a hack/workaround that is causing more issues than it solves.

mdedetrich commented 8 months ago

So for test-10-multi-project-dependsOn-includePackage-versions to pass it actually needs (Compile / sbt.Keys.packageBin) := bundle.value.

This looks like I will have to go back to the drawing board, possible even abandoning https://github.com/sbt/sbt-osgi/pull/103 and using another solution (such as explodedJar's).

eed3si9n commented 8 months ago

Commented on the issue - https://github.com/sbt/sbt-osgi/issues/104#issuecomment-1886077313