search

sbt / sbt-osgi

sbt plugin for creating OSGi bundles
Apache License 2.0
47 stars 43 forks source link

Remove sbt 0.13.x support and syntax improvements #118

Closed mdedetrich closed 7 months ago

mdedetrich commented 7 months ago

Removes sbt 0.13.x support since its ancient, syntax improvements, use sbt slash syntax and also use lazy val's

mkurz commented 7 months ago

Why not replace https://github.com/sbt/sbt-osgi/blob/0973c606b8d4352f94dde26f7c0605008a3a42b8/src/main/scala/com/typesafe/sbt/osgi/SbtOsgi.scala#L38 with https://github.com/sbt/sbt-osgi/blob/0973c606b8d4352f94dde26f7c0605008a3a42b8/src/main/scala-sbt-1.0/com/typesafe/sbt/osgi/SbtCompat.scala#L9 and delete src/main/scala-sbt-1.0/com/typesafe/sbt/osgi/SbtCompat.scala? Also that line needs to be changed to the newer sbt slash syntax anyway.

mdedetrich commented 7 months ago

@mkurz Done, thanks

mdedetrich commented 7 months ago

@mkurz Sorry for pinging you but can you review this PR? I have another fix coming through and I coded it against these changes (see https://github.com/apache/incubator-pekko/issues/1039#issuecomment-1909123323 for context) and it would be good to get it out soon