search

sbt / sbt-osgi

sbt plugin for creating OSGi bundles
Apache License 2.0
47 stars 43 forks source link

Add and apply scalafmt #122

Closed mdedetrich closed 7 months ago

mdedetrich commented 7 months ago

Although there are other PR's open its highly likely they are still dead and/or they are trivial in size and with the amount of work being done on sbt-osgi its best to get the formatter in sooner rather than later.

As always, if you are going to merge make sure to do either a "Create a merge Commit" or "Rebase and Merge" but not "Squash and Merge" since I need to add the format commit byitself to a .git-blame-ignore-revs. After PR is merged you can also add a branch check for the Code is formatted to prevent unformatted PR's being merged into main.

mdedetrich commented 7 months ago

Sure thing, I have been doing the same in other sbt community plugins so it shouldn't be controversial

SethTisue commented 7 months ago

As always, if you are going to merge make sure to do either a "Create a merge Commit" or "Rebase and Merge" but not "Squash and Merge"

I just disabled squash merging in the repo settings.