test-08-failOnClassesExcludedFromJarStar fail

[xuwei-k]

[info] [info] Validating all packages are set private or exported for OSGi explicitly...
[info] [success] Total time: 1 s, completed Aug 12, 2017 1:49:18 AM
[error] x sbt-osgi / test-08-failOnClassesExcludedFromJarStar
[error]    {line 1}  Command succeeded but failure was expected
[trace] Stack trace suppressed: run last *:scripted for the full output.
[error] (*:scripted) Failed tests:
[error]     sbt-osgi / test-08-failOnClassesExcludedFromJarStar
[error] Total time: 27 s, completed Aug 12, 2017 1:49:19 AM

[ktoso]

I don't maintain this plugin ;) I just fixed a bug once

[xuwei-k]

You have added this test in https://github.com/sbt/sbt-osgi/commit/5b93fbea3e7692fa85f82709164b94f0fe5c007e.

Should we remove this test? or fix as follows?

- -> verify-bundle
+ > verify-bundle

https://github.com/sbt/sbt-osgi/blob/eaa13ae6b8566ab37fe67ddc04f5ecdac7a6e153/src/sbt-test/sbt-osgi/test-08-failOnClassesExcludedFromJarStar/test#L1

http://www.scala-sbt.org/0.13/docs/Testing-sbt-plugins.html

# starts a one-line comment
> name sends a task to sbt (and tests if it succeeds)
$ name arg* performs a file command (and tests if it succeeds)
-> name sends a task to sbt, but expects it to fail
-$ name arg* performs a file command, but expects it to fail

[ktoso]

I see, I'll get back to this once at a computer then. Thanks for reporting

[ktoso]

I'm working on this today

[ktoso]

It was an actual bug. Submitting PR.