search

sbt / sbt-osgi

sbt plugin for creating OSGi bundles
Apache License 2.0
47 stars 43 forks source link

Fix make sure the package does not override the bundle #79

Closed romainreuillon closed 1 year ago

romainreuillon commented 1 year ago

On our build some bundle gets replaced by simple package due to the asynchronicity of the task. This makes sure that the package task is executed before the bundle one.

eed3si9n commented 1 year ago

I honestly don't know how this plugin is being used, so I'd let you decide. I guess something to think about is potential impact of rewiring Compile / packageBin, which might be used by other plugins like sbt-native-packager or sbt-assembly. If so this would be a subtle breaking change that at least should be advertised as such in the release note.

mdedetrich commented 1 year ago

I think its safe to then leave this for a later release so not too much gets released at once.

mdedetrich commented 1 year ago

So due to https://github.com/sbt/sbt-osgi/issues/93#issuecomment-1772818411 I am going to merge this now and then cut a release so that we can verify it fixes the regression that was introduced in 0.9.5

mdedetrich commented 1 year ago

Closing this PR in favour of https://github.com/sbt/sbt-osgi/pull/95 because I don't have permissions on @romainreuillon branch in order to add a merge commit so this PR can be merged