search

sbt / sbt-pom-reader

Translates xml -> awesome. Maven-ish support for sbt.
Other
76 stars 27 forks source link

Extract non SBT project #50

Closed nightscape closed 8 months ago

nightscape commented 6 years ago

I am planning to add similar functionality for reading POMs to Mill. It would be helpful to reuse as much code as possible from this project, so I split out the SBT-independent stuff into an extra project that I can use in Mill. I hope this is ok in principle with you. If so, I'd be happy for any feedback / improvement proposals :smiley:

blast-hardcheese commented 6 years ago

I have no objections to this; are you planning on depending on sbt-pom-reader from mill-pom-reader or similar?

nightscape commented 6 years ago

It would be great if the non-SBT part could be published independently. I've set up the SBT build of sbt-pom-reader so that this is a separate project. Right now I have publishLocaled this project and am writing the corresponding Mill code. So far it's working smoothly.

blast-hardcheese commented 6 years ago

Ah, I missed that in the refactor -- I see pom-model now. Do you anticipate any further changes to this project?

nightscape commented 6 years ago

I just went through the code again to check if more can be extracted to the pom-model project, but the stuff that's still in the plugin project is quite specific to SBT. So I think there wouldn't be much more changes upcoming. Are the project names and Maven coordinates ok like they are? I put the pom-model under the organization com.typesafe because it's independent of SBT. Otoh, only members of the com.typesafe organization can then publish the artifacts to Maven central afaik.

nightscape commented 6 years ago

@blast-hardcheese Ping 😉

blast-hardcheese commented 6 years ago

@nightscape Hey, sorry for dropping the ball here. I have no objections, I can merge but I'm not sure I have permissions to release though. I'll most likely be able to proceed later this week.

nightscape commented 6 years ago

Ok. If it turns out to be a problem to release in the com.typesafe namespace, we can also move the non-SBT stuff to com.typesafe.sbt. Might lead to minor confusions, but most people won't see this anyway.

nightscape commented 6 years ago

Hi @blast-hardcheese, do you have any news regarding publishing permissions? If you don't have them, maybe @eed3si9n could chime in?

gemelen commented 8 months ago

It seems not relevant anymore (for a long time) to the originating project, so I want to close this particular PR as obsolete.

I like the idea itself of having a build tool independent, intermediary project presentation, but likely there is no demand for it.

@nightscape sorry to ping you for the 6-year old issue, bu may I have you confirmation? :)

nightscape commented 8 months ago

Yes, confirmed 👍 I'm not encountering many Maven projects ATM.