search

sbt / sbt-pom-reader

Translates xml -> awesome. Maven-ish support for sbt.
Other
76 stars 27 forks source link

Supported profiles and additional sources in pom. #6

Closed ScrapCodes closed 10 years ago

ScrapCodes commented 10 years ago

Fixed a minor issue, where we don't need to fail if user does not have ~/.m2/some/settings.xml file.

TODO: Support maven's test-jars somehow !

jsuereth commented 10 years ago

So, this PR appears to be THREE separate things. I love what you want to do in each, but it'd be ideal if you could submit three separate PRs.

  1. The settings not existing can be merged immediately
  2. The profile support looks good, except for altering the build/version number scheme.
  3. Supporting the build-helper source directories also looks good, although I think that code should be in a separate object denoting it's specifc to adapting the build-helper plugin. It's inevitable that we support key maven plugins in here, but I want to denote when/where we do so.

Otherwise looks great! THanks so much for the contribution

ScrapCodes commented 10 years ago

Hey thanks this is supposed to be the fastest feedback I have ever received. I have just created a lot of PRs for you. I might need some of your help too.

jsuereth commented 10 years ago

Awesome! reviewing right now.