search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Remove NowListeningEvent, Stopped, NeedRebootEvent #101

Closed havocp closed 10 years ago

havocp commented 10 years ago

I believe these were leftovers from requirements of the old way sbt-remote-control worked. NeedRebootEvent never happens anymore. NowListeningEvent and Stopped are replaced by the onConnect / onError callbacks on SbtClient.

havocp commented 10 years ago

I think waiting for any setting or the build structure would work as you say. The NowListeningEvent was re-broadcast anytime someone asked to listen to events, which made its semantics unclear - I started to fix that then said wait let's just nuke it.

Incidentally would anyone ever NOT ListenToEvents? maybe having to ask to listen just creates a weird race where you miss some events on startup.

jsuereth commented 10 years ago

Yeah, I think people may not actually care about about events, and just want to execute things. "ListenToEvents" would be better if you could register a filter for the server side.

E.g. the terminal ONLY wants log events, that's all.

In any case, we can fix that shortly. We'll merge this and I'll hold my reservations for later.