add Unlisten requests matching all Listen requests

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks

Other

74 stars 14 forks source link

add Unlisten requests matching all Listen requests #105

Closed havocp closed 10 years ago

havocp commented 10 years ago

These do not keep a count, so if a client tried to listen from two unrelated pieces of code it would be unable to cleanly unlisten. This is OK in our current design because the SbtClient API keeps a client-side count and only listens or unlistens one time on the transitions between 0 and 1 listener. It does require client APIs to be smart about this, which is probably fine.

jsuereth commented 10 years ago

Looks great, but one major flaw in the logic.

havocp commented 10 years ago

thanks, should be fixed now

jsuereth commented 10 years ago

LGTM, mergeable now, but may need another flag.

jsuereth commented 10 years ago

LGTM