search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

allow watching task values without running tasks #108

Closed havocp closed 10 years ago

havocp commented 10 years ago

This leaves some pretty large and important TODO, but they were already there. For now I'm just wanting to be able to watch without running so I can control when stuff runs in the integration tests.

jsuereth commented 10 years ago

LGTM. I'll add the cache to the top of my queue.

Those are HUGE todos, and the "synthetic" stuff, does it go away if we have a client-side cache?

havocp commented 10 years ago

I think to prime the client side cache you need either the synthetic events or just getter requests (GetBuildStructure GetSetting and I guess the existing requestExecution for tasks). I'd probably go for just the getters but maybe when trying to code it you'd see which is cleaner.

havocp commented 10 years ago

I'm thinking the non-lazy watch on tasks may simply be a bad idea; too many side effects, no way to handle interaction. Perhaps a getLastResult(TaskKey):Option which just checks client cache, and then if you want new results you have to requestExecution manually. For settings and build structure the non-lazy watch seems safe since getting the value has no side effects. Anyway, can sort out as part of the cache patch.

jsuereth commented 10 years ago

Hmm, yeah. good points...

havocp commented 10 years ago

Travis passed