search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

add TestExecution testing execution engine #111

Closed havocp closed 10 years ago

jsuereth commented 10 years ago

LGTM - with one question about tests based on log events.

havocp commented 10 years ago

I believe log message lines have to stay in order or the UI will be f-d up. Stack frames in an exception out of order for example.

MAYBE we want to allow ourselves to have no defined order between stdout and stderr writes (only guarantee order on same stream) but I suspect we are all synchronous right now and do order even that. We'd have to go out of our way to send the events from a thread pool to get them reordered.

jsuereth commented 10 years ago

Right, but the tasks themselves are run in parallel, so you have to know that you're calling a task chain that has explicit dependencies, otherwise the order of events is arbitrary.

Are these tests ensuring ordering without forcing EXACT sequenece of logs?

havocp commented 10 years ago

I tried not to rely on sequencing between tasks, only logs from a single task? where are you worried about?

jsuereth commented 10 years ago

Ah, ok. I just didn't look deep enough. Should be fine.