search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Use a serialized executor to fix SimpleConnector close #113

Closed havocp closed 10 years ago

havocp commented 10 years ago

We were depending on the order (open first, close second) but throwing callbacks into the default Scala executor which does not guarantee any order. Switch to a custom executor which serializes everything. We can't just use same thread executor because one of these callbacks joins the thread that would run the callback.

jsuereth commented 10 years ago

LGTM once travis passes.

havocp commented 10 years ago

Fixed dumb race in the test. It worked on my machine!

havocp commented 10 years ago

Bah, now travis is just timing out. But the tests pass on my machine ;-)

jsuereth commented 10 years ago

ok, I'll merge then complain bitterly if it's broken.