Fix lookup of launcher to work when running inside sbt's run task.

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks

Other

74 stars 14 forks source link

Fix lookup of launcher to work when running inside sbt's run task. #121

Closed jsuereth closed 10 years ago

jsuereth commented 10 years ago

This ensures that when running run tasks in sbt that depend on sbt-client, you'll still be able to accurately detect an sbt-launcher.jar. The detection isn't perfect, but won't cause wonky issues right now.

Review by @havocp

havocp commented 10 years ago

Looks like an actual Travis failure (on JDK7 only) but also looks likely unrelated to this change. Maybe our integration tests are racy.

havocp commented 10 years ago

LGTM if you don't think the CI failure is related to this change.

jsuereth commented 10 years ago

ouch, yeah that's the kill-switch test being racy. I'll fix that in a follow-on PR. DOes the change itself look ok?

jsuereth commented 10 years ago

No, it's definitely a racy-test for the kill-command.