sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Creates a mechanism whereby plugins/tools can register serialization. #124

Closed jsuereth closed 10 years ago

jsuereth commented 10 years ago

Allow plugins/tools to register serialization handlers on both sides of the Json protocol.

Notes: This is still missing some way of preventing memory leaks on registered serializers, or evicting registered handlers on a classloader-death basis.

Review by @havocp cc> @skyluc

jsuereth commented 10 years ago

Also in terms of how to register serializers, I'm trying to figure that out practically...

I do want reusable "register serializer" code.... it's the only practial way to go.

havocp commented 10 years ago

Travis failure may be a real problem?

jsuereth commented 10 years ago

@havocp It's odd, it works locally for me. Do you mind trying it out?

havocp commented 10 years ago

Tests pass locally for me too.

Is this ready to merge then? Your fixes LGTM

jsuereth commented 10 years ago

Seems fine to me, but I may test on windows quick