search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Activator 1.1.x scala upgrade #128

Closed henrikengstrom closed 10 years ago

henrikengstrom commented 10 years ago

Rolls this branch up to the sacred land of Scala 2.11.

havocp commented 10 years ago

do integration tests pass on this?

looks fine if it works

jsuereth commented 10 years ago

looks good to me now, assuming tests pass.

henrikengstrom commented 10 years ago

Anyone else that can run the integration tests for the activator-1.1.x branch? I cannot get them to run without any issues (and the same issues are present on this branch, i.e. no regression from that point of view).

havocp commented 10 years ago

on activator-1.1.x I have a failure to launch with an agent.

ESC[0m[ESC[0minfoESC[0m] ESC[0m[DEBUG] [05/20/2014 19:59:36.699] [IntegrationTest-akka.actor.default-dispatcher-2] [akka://IntegrationTest/user/sbt-process-1/underlying] sbt out: Error occurred during initialization of VMESC[0m
ESC[0m[ESC[0minfoESC[0m] ESC[0m[DEBUG] [05/20/2014 19:59:36.703] [IntegrationTest-akka.actor.default-dispatcher-2] [akka://IntegrationTest/user/sbt-process-1/underlying] sbt out: agent library failed to init: instrumentESC[0m
ESC[0m[ESC[0minfoESC[0m] ESC[0m[DEBUG] [05/20/2014 19:59:36.703] [IntegrationTest-akka.actor.default-dispatcher-2] [akka://IntegrationTest/user/sbt-process-1/underlying] sbt err: Error opening zip file or JAR manifest missing : ./../../../../../../example-agent/target/sbt-rc-example-agent-1.0.jarESC[0m
havocp commented 10 years ago

since activator master is now using this I guess we should merge it and then we can try to fix the tracing thing once tracing even theoretically works.