search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Wip/proxy support #13

Closed antigremlin closed 11 years ago

antigremlin commented 11 years ago

This adds support for *.nonProxyHosts properties and SOCKS proxy properties. I also would like to add user.home to pass-through properties to be able to override broken home paths on Windows.

havocp commented 11 years ago

The first commit adds user.home and the next one removes it, intentional?

Could you click through the CLA at http://www.typesafe.com/contribute/cla using your github account? should be quick and easy

Thanks!

antigremlin commented 11 years ago

Removing user.home was intentional, because passing this property through to a child JVM is very unusual. This is not the best way to solve the problem as long as other forked JVMs might exist. For sbt we'd better use sbt.global.base and sbt.ivy.home consistently.

antigremlin commented 11 years ago

And yes, I've signed the CLA...

havocp commented 11 years ago

Rock on, thanks for fixing this.

jsuereth commented 11 years ago

+1 many thanks