search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Async-ify SbtClient socket errors #131

Closed havocp closed 10 years ago

havocp commented 10 years ago

The problem here was that SbtClient randomly threw SocketException when you called close(), and this meant API users had to catch it all over the place. Instead, we want requests with a reply (things returning a Future) to fail the future, and requests with no reply to just fire-and-forget (ignoring any socket exceptions).

jsuereth commented 10 years ago

This LGTM, nice cleanups.

It looks like JDK6 may be broken. I'm not sure I care, but something we should figure out soon...