search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Port to play 2.3.0 final, scala 2.11.1 #138

Closed havocp closed 10 years ago

jsuereth commented 10 years ago

LGTM, let's wait for travis.

jsuereth commented 10 years ago

@havocp This is the null pointer exception I was mentioning I kept seeing. I'll investigate locally.

jsuereth commented 10 years ago

@havocp Check out my fix quick.

havocp commented 10 years ago

So the Java std library throws NPE if you use a closed writer? w.t.f. But if that's the case I don't know a better fix than yours, we can't fix the std lib.

jsuereth commented 10 years ago

@havocp It turns out it was a JDK6 specific bug, fixed in JDK7.

havocp commented 10 years ago

got it. lgtm. maybe make the comment on NPE catch explain that it's a jdk6 workaround ?

jsuereth commented 10 years ago

good point. LOOK IT PASSED!