Send log events earlier, so we get events during sbt boot

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks

Other

74 stars 14 forks source link

Send log events earlier, so we get events during sbt boot #161

Closed havocp closed 10 years ago

havocp commented 10 years ago

The goal here is to get log events if sbt fails to start up due to missing plugins, syntax errors in the build config, and so on.

This commit introduces a refactor where ServerEngine can go through a ReadOnlyServerEngine-mediated event sink rather than directly using eventListeners. For now it only uses the mediated event sink for log events, but in the future as noted in TODO I want to use it for all events and solve the problem of bringing new clients up to speed on active execution state.

jsuereth commented 10 years ago

Generally looks good, but a few meta/design/architecture-comments.

jsuereth commented 10 years ago

Ok, I'm going to merge this one ot make #168 easier to refactor/work with.