Split SbtChannel out of SbtClient

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks

Other

74 stars 14 forks source link

Split SbtChannel out of SbtClient #182

Closed havocp closed 10 years ago

havocp commented 10 years ago

This is mostly a code cleanup to separate concerns; it also allows us to make more assumptions in SbtClient because it becomes possible to use the raw channel if someone has custom needs.

jsuereth commented 10 years ago

This looks AWESOME. one comment on binary compatibility, the rest is just minor tidbits, not as important.

havocp commented 10 years ago

Ready for another look

havocp commented 10 years ago

Travis fixed now. Had to restart it.

jsuereth commented 10 years ago

LGTM