sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Remove global mutable serializer registry #185

Closed havocp closed 10 years ago

havocp commented 10 years ago

This is the logical extension of earlier work to always pass the Writes around (and to pass only Writes, not the whole Format).

With those earlier cleanups it isn't such a big deal to pass the serialization registry around where it's needed too.

jsuereth commented 10 years ago

Generally LGTM

jsuereth commented 10 years ago

You're right, this conflicts now and needs to be refreshed.

havocp commented 10 years ago

Merged, and cleaned up a bit. I sorted out the race with registration in SbtClient because I needed to shuffle that code anyhow to make the channel have the serializations. Two additional pieces of work that might be nice:

I think we can push both of those into the future sometime.

havocp commented 10 years ago

Re-merged and travis passing.