Remove protocol type aliases from sbt.client

havocp commented 10 years ago

in some cases (specifying a type parameter for example) these don't seem to be interchangeable with the original type
having two paths to the same type name is confusing for API users
we only had a haphazard subset of sbt.protocol aliased into sbt.client anyway
DRY

corruptmemory commented 10 years ago

LGTM

corruptmemory commented 10 years ago

This passed for me the second time:

[info]  --- Integration Test Report ---
[info]  *           com.typesafe.sbtrc.it.execution.TestExecution [ PASSED ]
[info]  *            com.typesafe.sbtrc.it.loading.CanCancelTasks [ PASSED ]
[info]  *             com.typesafe.sbtrc.it.loading.CanKillServer [ PASSED ]
[info]  *      com.typesafe.sbtrc.it.loading.CanLoadSimpleProject [ PASSED ]
[info]  * com.typesafe.sbtrc.it.loading.CanUseUiInteractionPlugin [ PASSED ]
[success] Total time: 95 s, completed Sep 16, 2014 3:21:56 PM

But the first time this failed the com.typesafe.sbtrc.it.loading.CanCancelTasks test. I suspect a race condition.

havocp commented 10 years ago

CanCancelTasks has had a race for a while, it fails on Travis sometimes too. Needs investigation.

sbt / sbt-remote-control

Remove protocol type aliases from sbt.client #203