search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

starting one-way trip #223

Closed eed3si9n closed 9 years ago

eed3si9n commented 9 years ago

Added tests for the current json serialization. The purpose of the one-way trip is to persist the output into files, so we can verify that we can deserialize them back to protocol case classes as we change the serialization format and/or the case class.

/cc @jsuereth

jsuereth commented 9 years ago

one-way-trip looks like a super handy method.

However, you want to make sure you test testRawStructure messages. For the analysis stuff you're testing, That may change in the future (cc @corruptmemory ), so it's good to have it, but I'm more worried about making sure our control protocol is stable.

Thanks for getting this in.

corruptmemory commented 9 years ago

Generally speaking, this all looks right.

eed3si9n commented 9 years ago

During the last commit, apparently c4320287670c74d497a71e64f8b27e7bffe5cf91 came in between two Travis jobs, succeeding openjdk6 but failing openjdk7. I just rebased to master and removed the test for protocol.RequestCompleted, which no longer exists.

jsuereth commented 9 years ago

LGTM

jsuereth commented 9 years ago

Also, I kinda feel the 'type' tests might belong in a different file, but ok for now.