sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Move Format to Message (not subtypes) and clean up hackarounds #226

Closed havocp closed 9 years ago

havocp commented 9 years ago

We want Message to always be serialized with a discriminator, and it will always be a sealed trait, so it makes sense to do the serialization at the Message level and make all the subtype serializers into private implementation details. This also removes the hacks we had (sendJsonFilter, etc.) to add the discriminator later in the process.

havocp commented 9 years ago

This is a net decrease in lines of code and it also privatizes a bunch of types that were public.

jsuereth commented 9 years ago

This looks ok to me. Might need to merge with @eed3si9n 's protocol tester thingy.

havocp commented 9 years ago

Now merged with master.

havocp commented 9 years ago

Now Travis-approved

jsuereth commented 9 years ago

LGTM