search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

add java version check to enforce 1.6 publishing #229

Closed havocp closed 9 years ago

corruptmemory commented 10 years ago

LGTM. Let's see what Travis says ;-).

jsuereth commented 10 years ago

LGTM

jsuereth commented 10 years ago

WOAH, so this will always fail the CI. You need a way to make sure we still work on JDK7

jsuereth commented 10 years ago

i.e. we test on OpenJDK6 + OpenJDK7. the hook for java version check means you cant run integration tests.

havocp commented 10 years ago

To really be testing our intended setup we need to build the libs with 6 then build the integration tests with 7. I don't think we can make travis do that...

We could have some kind of magic env var we set in travis to ignore the version check - but we would be testing a scenario we never want to use ... should we do that or drop the jdk 7 test?

jsuereth commented 10 years ago

I'd prefer not to drop JDK7 as there were fixes in that JDK that alter some of the forkign stuff

jsuereth commented 9 years ago

closing from inaction.