search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Privatize JsonValue, publicize SerializedValue to/fromJsonString #249

Closed havocp closed 9 years ago

havocp commented 9 years ago

We aren't sure how we want to implement SerializedValue, so make its hierarchy entirely opaque, and just expose to/from string.

jsuereth commented 9 years ago

Generally LGTM. I think the equality check is sketchy for JValue and we should avoid it (when we alter formats it'll probably become an issue again). By the time it bites us we'll have forgotten all the pain we just had.

Still, besides minor comments, ok to merge.

havocp commented 9 years ago

All comments addressed I think.

jsuereth commented 9 years ago

LGTM, once tests pass, good to merge.