search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Document/unexpose anything we want in our public-supported API for 1.0/s... #250

Closed jsuereth closed 9 years ago

jsuereth commented 9 years ago

...bt 0.13.x.

Review by @havocp

havocp commented 9 years ago

Shouldn't everything in the json package be private[serialization] ?

jsuereth commented 9 years ago

The json package itself is a private/implementation detail. I'll make it further private thugh.

jsuereth commented 9 years ago

@havocp / @eed3si9n The JSON format is now hidden inside the serialziaiton package. All usage is exposed via SerializedValue and all tests are updated to reflect this. It was actually only tests whcih used scala-pickling directly.

havocp commented 9 years ago

maybe we need TypeExpressionPicklers, wdyt. otherwise lgtm.

havocp commented 9 years ago

LGTM.

havocp commented 9 years ago

Travis 2/3, merging.