Bake a cake of picklers.

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks

Other

74 stars 14 forks source link

Bake a cake of picklers. #251

Closed jsuereth closed 9 years ago

jsuereth commented 9 years ago

Bake default picklers into serialziatoin package object.
Remove as many refernces to scala-pickling.
REmoves CoreProtocol for just importing sbt.serialization._
Fixes all tests

THE CAKE IS BAKED. review by @eed3si9n @havocp

corruptmemory commented 9 years ago

GACK! Looks like I have to do another update to Play with this one. (That's OK :-) )

havocp commented 9 years ago

LGTM

eed3si9n commented 9 years ago

generally LGTM. I would still like to have some nicer function for pickling and unpickling like

sbt.serialization.toJsonString(Apple(1))
sbt.serialization.fromJsonString[Apple](appleExample)

jsuereth commented 9 years ago

@eed3si9n I think it's a good idea, but given the significance of the change, let's merge this as-is and we can add convenience in later (as long as the shape of exposed API is good enough, adding more is easy. Removing is impossible)