Remove Analysis and related data structure

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks

Other

74 stars 14 forks source link

Remove Analysis and related data structure #252

Closed eed3si9n closed 9 years ago

eed3si9n commented 9 years ago

/review @havocp, @jsuereth

corruptmemory commented 9 years ago

Generally LGTM, but failing test:

com.typesafe.sbtrc.it.loading.CanLoadSimpleProject [FAILED]

All that code ... sniff.

jsuereth commented 9 years ago

Once you get tests working again, this looks ok.

Also a note: we can serialize Analysis as a string in the future, inside a serialized value. We do not need to have it be part of "protocol" (nor do any task results need to be there).

eed3si9n commented 9 years ago

@jsuereth Which tests? Integration tests passed on 2/3 jvms on Travis. The staleness of saved JSON is I don't think relevant to Analysis removal.