search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Exchange protocol version and feature tags as each client registers. #274

Closed havocp closed 9 years ago

havocp commented 9 years ago

Last minute thought - should we throw this in, or something like it?

Right now we just ignore it, but it's probably easier to have the info there and start using it later than to not have it there and add it later. In particular changing the response to RegisterClientRequest from ReceivedResponse to a specific type might be safer to do now.

jsuereth commented 9 years ago

Yes we should add this now.

jsuereth commented 9 years ago

Yeah. As long as the stringy version used in the filesystem matches...

havocp commented 9 years ago

I de-stringified us. If this looks good otherwise, I will move saved-protocol/0.1 to saved-protocol/1, and also regenerate it to include this new stuff.

havocp commented 9 years ago

Fixed the tests (hopefully). Discovered a weirdness that ExecutionWaiting also includes ClientInfo (so UIs can display which client launched an execution), but protocolVersion and featureTags aren't really needed in that context. But fixing it ends up being weird too, because you get BasicClientInfo and RegistrationClientInfo or some other split like that. Thoughts welcome.

Once the patch looks ok I'll move 0.1 to 1 in saved-protocol, which will bloat up the diff here with noise.

jsuereth commented 9 years ago

LGTM

jsuereth commented 9 years ago

merging, it's the flaky akka test again.

jsuereth commented 9 years ago

merging, it's the flaky akka test again.