search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Possible fix for SbtConnectionProxySpec #280

Closed corruptmemory closed 9 years ago

corruptmemory commented 9 years ago

I think this should have better inter-thread sharing sematics.

corruptmemory commented 9 years ago

The real test is if Travis agrees with me.

havocp commented 9 years ago

maybe add some logging to each step in the sequence of events that's supposed to happen, and see if we can understand what goes wrong?

corruptmemory commented 9 years ago

That's such a crazy idea it might just work! :-)

Yeah, going to get around to that as well. One concern is that this may be some kind of subtle timing error that the extra logging may mask.

The test is currently failing for openjdk 6; I'm going to install that locally to see if I can make it happen on my machine.

corruptmemory commented 9 years ago

Well, found the issue. Something about the test is broken. Nothing related to JDK versions or anything. Will fix sometime today.

corruptmemory commented 9 years ago

Nope, not just a wrong test. Wrong code. HA! Classic problem in code evolution: there is a small amount of code left over from an earlier version of the SbtConnectionProxy that is now wrong. Yay tests! :-)