search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Add pickler for BuildDependencies #286

Closed nkly closed 9 years ago

lightbend-cla-validator commented 9 years ago

Hi @dancingrobot84,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://www.typesafe.com/contribute/cla

lightbend-cla-validator commented 9 years ago

Hi @dancingrobot84,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://typesafe.com/contribute/cla

jsuereth commented 9 years ago

The change looks good (minus the build failure). What i'm debating right now is whether or not we should just return this info in the MinimalBuildStructure/MinimalProjectStructure, as I think it's valuable there...

dpratt commented 9 years ago

Adding this to Minimal(Project|Build)Structure would be incredibly useful for me - I've been working on an IntelliJ sbt-rc plugin and having this available immediately at project loading time would make the code paths that construct the relevant IntelliJ model bits quite simpler.

jsuereth commented 9 years ago

Hey @dpratt / @dancingrobot84 Sorry for the delay. I'd like to adapt this PR so that the project deps show up in minimal build structure. So, we can leave this as reference but I plan to eventually close in favor of that approach.

@dancingrobot84 didn't chime in, but will that solve the issue you need us to solve?

nkly commented 9 years ago

@jsuereth Yeah, it will solve.

jsuereth commented 9 years ago

Closing in favor of #289