search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Wip/jsuereth model view server #61

Closed jsuereth closed 10 years ago

jsuereth commented 10 years ago

Let's merge my branch back into the mainline WIP. Then, the rest of the team can run their experiments on their own WIP branches and I can safely push additions to my own without breaking everyone.

To clarify:

wip/model-view-server-api becomes the "feature" branch where we target all sbt-server commits. We synch to this branch to see the latest. wip/jsuereth-model-view-server-api becomes my own personal "patch" branch where i can issue pull requests for review. master will eventually receive the sbt-server updates once we're feature complete on the server.

Architecture: https://github.com/sbt/sbt-remote-control/wiki/Architecture-2.0 TODO list: #55

Review by @havocp and @skyluc (cc> @dotta @dragos @eed3si9n )

jsuereth commented 10 years ago

ping @havocp @skyluc

I realize it's a lot to read, but we did to an in person code review. What's a reasonable way to do an assessment before merging into the integration branch between us?

dotta commented 10 years ago

@jsuereth CompilationError events are not reported to the client - just making you aware of this in case you didn't know.

jsuereth commented 10 years ago

Yeah. Realized a bit late. There's a branch on sbt to expose the right hook for the server. Need to review/merge that

jsuereth commented 10 years ago

@dotta I updated #55 to reflect that lack of compiler errors showing up right now.

See the note yet merged 0.13.2 hook: https://github.com/sbt/sbt/commit/e543f6cd43af3fb69a8399444fa4edf77d45d31a

jsuereth commented 10 years ago

THANKS!

havocp commented 10 years ago

Leeeeeeeeeeeeeroy