search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Adds support for watching setting keys #71

Closed skyluc closed 10 years ago

skyluc commented 10 years ago

The value is send directly when the watch request is received. The listener is registered, but apparently there is no code to detect the changes.

Do I need to add a test? How do I add a test?

lightbend-cla-validator commented 10 years ago

Hi @skyluc,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Typesafe Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

http://typesafe.com/contribute/cla

jsuereth commented 10 years ago

Have you seen the integration tests?

Here's where I grab a key. I haven't tested the "watch setting" method yet, but it's a start: https://github.com/sbt/sbt-remote-control/blob/wip/model-view-server-api/integration-tests/src/main/scala/com/typesafe/sbtrc/it/loading/CanLoadSimpleProject.scala#L74-L76

jsuereth commented 10 years ago

And yes, if you can do an integration test, would be amazing. If not, let me know I can cover there :)

jsuereth commented 10 years ago

Besides integration test, LGTM. Feel free to merge.

skyluc commented 10 years ago

I added a step in the integration test.

jsuereth commented 10 years ago

Great! thanks much for the fix.