search

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

taskKey values no more sent to watchers #72

Open skyluc opened 10 years ago

skyluc commented 10 years ago

On the wip/model-view-server-api branch, messages are no more sent to client watching when the value of a task key is recomputed. It was working before, I believe my branch was based on ef211f5a28288817cd44d6f4985acd9b614ce4c5.

I have a commit which adds a test to the integration test, and which is failing: skyluc/sbt-remote-control@54e0628c7667dd131d0d82cf349c19caabc75121

If you have an idea of where the problem can be, I can have a look at it.

jsuereth commented 10 years ago

not sure, really. But something with the new event loop and passing the task value listening state at the right time (i.e. my be a synchronization issue).

jsuereth commented 10 years ago

Hmm, that test is actually passing for me... What hardware are you on?

jsuereth commented 10 years ago

nevermind, was testing the wrong branch. Looking at it now.

jsuereth commented 10 years ago

Alright, found it. Was a fun synchronization issue. ServerState was getting captures when the Command-Engine thread blocked, rather than AFTER it unblocked. The fix appears to work, I'm going to push your branch and issue a pull request.