sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks
Other
74 stars 14 forks source link

Add the `show` string to `ScopedKey` #74

Closed jsuereth closed 10 years ago

jsuereth commented 10 years ago

Review/use by @havocp

havocp commented 10 years ago

I guess we need to revive this PR?

jsuereth commented 10 years ago

yeah, but I need to rework it. As it stands, its bad for a few reasons. Let's chat a bit about it.

havocp commented 10 years ago

why didn't we just add an overload of requestExecution that takes a protocol.ScopedKey ? then we never need to worry about this (?)

jsuereth commented 10 years ago

We can do that. It's more an issue of trying to keep the "ScopedKey -> String" logic in one spot (on the server).

I'm going to close this in favor of a beter option.