Register uuid / configName / humanReadableName for each client

sbt / sbt-remote-control

Create and manage sbt process using unicorns and forks

Other

74 stars 14 forks source link

Register uuid / configName / humanReadableName for each client #77

Closed havocp closed 10 years ago

havocp commented 10 years ago

Several details worth discussing here but patch shows the broad outline.

uuid, generated client-side so the client has it without an extra round trip
configName, an ID we could use to recognize "the same" client and do things like save per-client configuration
humanReadableName, we might use to display which client triggered a certain task or things like that

jsuereth commented 10 years ago

LGTM

havocp commented 10 years ago

made them mandatory according to both client API and server as of this patch so not optional. Thought of two fixes here though: server should validate the two names eg not empty string, and need to send a reply to the registration request.

Think I'll just require that the config name is a-zA-Z0-9 or something so we never have to escape it anywhere.

small fixes incoming in new PR later.