search

sbt / sbt-rjs

RequireJs optimizer plugin for sbt-web
Other
39 stars 28 forks source link

Attempting to remove cdn using config and getting error #51

Open mfields106 opened 9 years ago

mfields106 commented 9 years ago

I have the following config:

RjsKeys.appBuildProfile := JS.Object( "appDir" -> RjsKeys.appDir.value, "baseUrl" -> RjsKeys.baseUrl.value, "dir" -> RjsKeys.dir.value, "generateSourceMaps" -> RjsKeys.generateSourceMaps.value, "mainConfigFile" -> RjsKeys.appDir.value / RjsKeys.mainConfigFile.value.getPath, "modules" -> RjsKeys.modules.value, "optimize" -> RjsKeys.optimize.value, "preserveLicenseComments" -> RjsKeys.preserveLicenseComments.value, "removeCombined" -> RjsKeys.removeCombined.value )

This produces error - Error: Error: Module loading did not complete for: ....

However when I run separately r.js directly on the app.build.js everything works.

Please help.

huntc commented 9 years ago

How about:

RjsKeys.webJarCdns := Map.empty

?

mfields106 commented 9 years ago

Tried and no affect. But anyways, how could that impact the anything as I am overriding the appBuildProfile and I am ignoring the web jar configuration completely?

I am having trouble understanding how it could fail when r.js is called from SBT vs when it is called directly. Part of my problem is I do not know how to debug the SBT Dist task. That may help me see what is actually being passed into the execution of r.js. From what I can see the version of r.js is correct the app.build.js does not change, however I cannot see what is the timeout being specified for example.

On Dec 30, 2014, at 11:41 PM, Christopher Hunt notifications@github.com wrote:

How about:

webJarCdns := Map.empty ?

— Reply to this email directly or view it on GitHub https://github.com/sbt/sbt-rjs/issues/51#issuecomment-68401594.

huntc commented 9 years ago

You stated that you wanted to avoid the CDN substitution. If you just re-declare webJarCdns and nothing else, then your goal should be achieved. You should not need to override appBuildProfile.

mfields106 commented 9 years ago

Did this and it seemed to work on my local Mac OS X, but failed to work on CentOS build server. I used the same app.build.js and called directly using r.js installed in node.js. This works, but when running from SBT it fails.

Could it be an issue with the timeout calculation?

On Dec 31, 2014, at 9:17 AM, Christopher Hunt notifications@github.com wrote:

You stated that you wanted to avoid the CDN substitution. If you just re-declare webJarCdns and nothing else, then your goal should be achieved. You should not need to override appBuildProfile.

— Reply to this email directly or view it on GitHub https://github.com/sbt/sbt-rjs/issues/51#issuecomment-68427658.

huntc commented 9 years ago

Yes it could certainly be a timeout issue

mfields106 commented 9 years ago

I have increased the timeout, upgraded SBT to the same version on my local computer and checked that requirejs optimizer when called separately on the same app.build.js works. Still when running I get the same error.

I do not understand what you are doing differently than simply calling r.js optimizer and I have failed to attach to SBT process in debug mode. This is very frustrating.

On Dec 31, 2014, at 3:12 PM, Christopher Hunt notifications@github.com wrote:

Yes it could certainly be a timeout issue

— Reply to this email directly or view it on GitHub https://github.com/sbt/sbt-rjs/issues/51#issuecomment-68440979.

huntc commented 9 years ago

I can take a look next week when I'm back at work. Meanwhile ensure you're using the latest versions of all plugins.

mfields106 commented 9 years ago

I have ensured I have the latest plugins. Please let me know when you can help and what you need?

On Jan 2, 2015, at 12:03 AM, Christopher Hunt notifications@github.com wrote:

I can take a look next week when I'm back at work. Meanwhile ensure you're using the latest versions of all plugins.

— Reply to this email directly or view it on GitHub https://github.com/sbt/sbt-rjs/issues/51#issuecomment-68499840.