search

sbt / sbt-rjs

RequireJs optimizer plugin for sbt-web
Other
39 stars 28 forks source link

WebJar CDN path issues #7

Closed huntc closed 10 years ago

huntc commented 10 years ago

As initially reported here: https://github.com/sbt/sbt-web/issues/39

We now avoid the webjar locator for CDN mapping as the version of the WebJar that it returned wasn't the right one for our needs. As a consequence the WebJars were being mapped incorrectly for the CDN.

CDN configuration is also enhanced so it also receives a mapping of WebJar organisations to CDNs. Thus you can now have many CDNs declared.

huntc commented 10 years ago

@jmparsons Please try out sbt-rjs with version 2014-05-24-9590e9b and confirm the fix. I've incorporated a test here so I'm quite confident, but it'd be good if you could try it also. Comments on the PR are also welcome.

jmparsons commented 10 years ago

Confirmed. It works. Thank you @huntc

pvlugter commented 10 years ago

Small style comment on map...flatten. And hard wrapped commit messages with short summary are friendlier. Changes look good to me. Nice one.

huntc commented 10 years ago

Thanks guys. The new release is published under version 2014-05-24-62a6f46.

huntc commented 10 years ago

Make that 1.0.0-2014-05-24-62a6f46