search

sbt / sbt-rjs

RequireJs optimizer plugin for sbt-web
Other
39 stars 28 forks source link

Updated to sbt 0.13.16 #82

Closed mebur closed 7 years ago

mebur commented 7 years ago

updated require.js to 2.3.5 (both rjs & requirejs for tests) set to scala 2.10 for now

this works for play 2.6.5

benmccann commented 7 years ago

Thank you for this!

I'm not sure about creating variables like appDirValue for every setting. It generally adds indirection that makes things less clear

Also, it looks like the build is failing. I'm not sure why since I'm on my phone, but can you take a look?

mebur commented 7 years ago

I will take a look later tonight or tomorrow.

Regarding the variables this seems like the path other plugins has taken to get around the new restrictions in sbt 0.13.16/scala 2.12 and up, unfortunatly I'm not familiar enough with sbt/scala to come up with a better solution.

Best regards // Patrik

Den 28 sep. 2017 18:38 skrev "Ben McCann" notifications@github.com:

Thank you for this!

I'm not sure about creating variables like appDirValue for every setting. It generally adds indirection that makes things less clear

Also, it looks like the build is failing. I'm not sure why since I'm on my phone, but can you take a look?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sbt/sbt-rjs/pull/82#issuecomment-332893750, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8fSguF-wPBQ6n0JyrGY5N6TfQ9YeYTks5sm8uWgaJpZM4Pnidv .