search

sbt / sbt-scalariform

sbt plugin adding support for source code formatting using Scalariform
258 stars 63 forks source link

Scalariform does not understand trailing comma #70

Open marekzebrowski opened 7 years ago

marekzebrowski commented 7 years ago

reproducer

case class A(
a: Int,
b:Int,
)
exp0nge commented 5 years ago

Is this ever going to be addressed?

charpov commented 5 years ago

It's a small thing, but so annoying.

exp0nge commented 5 years ago

@charpov use scalafmt instead

aij commented 5 years ago

@exp0nge scalafmt also has trouble with some trailing commas, though it's ok with most of them.

charpov commented 5 years ago

I tried scalafmt once and didn't like it. I don't remember why now. I'll give it another shot.

hubertta commented 1 year ago

This is an issue with scalariform, not with sbt-scalariform. I made a pull request in scalariform that takes care of this problem: https://github.com/scala-ide/scalariform/pull/296. Let's see if it gets merged and makes into a new release, then we could bump the scalariform version here in sbt-scalariform to make the fix available for this plugin.