search

sbt / zinc

Scala incremental compiler library, used by sbt and other build tools
Apache License 2.0
334 stars 121 forks source link

[1.x] Emit `SourceInfos` when incremental compilation fails #1306

Closed Friendseeker closed 1 month ago

Friendseeker commented 10 months ago

This PR implements https://github.com/sbt/zinc/issues/932 via building SourceInfos from analysis callback and pass them to handleErrors in CompilerBridge.scala.

c.c. @adpi2

Friendseeker commented 1 month ago

@adpi2 Reopened this PR and added a unit test.

@eed3si9n c.c. https://github.com/sbt/zinc/issues/932#issuecomment-2376210214 for reason for revisiting this PR. I am thinking if this can be merged along with #1309 as both involves adding AnalysisCallback3.

eed3si9n commented 1 month ago

LGTM. could you squash the commits and add problem and solution descriptions in the commit message plz?

Friendseeker commented 1 month ago

@eed3si9n Squashed!