search

sbt / zinc

Scala incremental compiler library, used by sbt and other build tools
Apache License 2.0
333 stars 118 forks source link

Fix build #1347

Closed eed3si9n closed 5 months ago

eed3si9n commented 5 months ago

https://github.com/protocolbuffers/protobuf/releases/tag/v25.3

Also clean up protoc resolution.

SethTisue commented 4 months ago

@eed3si9n after this change, I can no longer zincPersistCore / Protobuf / protobufRunProtoc, either in the community build (where I noticed the problem) or locally?

[error] java.lang.RuntimeException: protoc was not found: Vector()
[error]     at scala.sys.package$.error(package.scala:30)
[error]     at sbtprotobuf.SbtProtobuf$.extractFile(SbtProtobuf.scala:72)
[error]     at sbtprotobuf.ScopedProtobufPlugin.$anonfun$projectSettings$24(ProtobufPlugin.scala:107)
[error]     at sbtprotobuf.SbtProtobuf$.withFileCache(SbtProtobuf.scala:60)
[error]     at sbtprotobuf.ScopedProtobufPlugin.$anonfun$projectSettings$23(ProtobufPlugin.scala:106)
[error]     at scala.Function1.$anonfun$compose$1(Function1.scala:49)
...
eed3si9n commented 4 months ago

@SethTisue Are you on some branch? On e902ec9c4efe529a2516a896758d662b2662d06e it works fine on my machine:

sbt:zinc Root> show zincPersistCore / Compile / sources
[info] compiling 2 protobuf files to /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/target/src_managed/main/compiled_protobuf
[info] Compiling schema /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/src/main/protobuf/schema.proto
[info] Compiling schema /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/src/main/protobuf/zprof.proto
[info] Compiling protobuf
[info] Protoc target directory: /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/target/src_managed/main/compiled_protobuf
[info] * /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/target/src_managed/main/compiled_protobuf/sbt/internal/inc/Schema.java
[info] * /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/target/src_managed/main/compiled_protobuf/sbt/internal/prof/Zprof.java
SethTisue commented 4 months ago

yeah I'm at e902ec9c4efe529a2516a896758d662b2662d06e

and hmm, well, it still fails in the community build (both on Jenkins and locally), but it doesn't fail for me locally anymore outside of dbuild. I don't know what to make of it

I'll poke at it some more, I guess