sbt / zinc

Scala incremental compiler library, used by sbt and other build tools
Apache License 2.0
333 stars 118 forks source link

Update scala-xml to 2.3.0 #1355

Closed scala-steward closed 4 months ago

scala-steward commented 4 months ago

About this PR

πŸ“¦ Updates org.scala-lang.modules:scala-xml from 2.2.0 to 2.3.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number The following files still refer to the old version number (2.2.0). You might want to review and update them manually. ``` project/plugins.sbt ```
βš™ Adjust future updates Add this to your `.scala-steward.conf` file to ignore future updates of this dependency: ``` updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-xml" } ] ``` Or, add this to slow down future updates of this dependency: ``` dependencyOverrides = [{ pullRequests = { frequency = "30 days" }, dependency = { groupId = "org.scala-lang.modules", artifactId = "scala-xml" } }] ```

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, old-version-remains, commit-count:1

eed3si9n commented 3 months ago

See https://github.com/sbt/sbt/issues/7564.

I don't know if we should use Scala Steward for Zinc since any change to version usually have some consequence.

SethTisue commented 3 months ago

I agree that I should have given more thought to this PR before approving it. That's on me. But I think the Steward PRs are valuable to have regardless, since they notify us when potential upgrades exist that should be considered.

In my opinion, it should work for zinc to have a newer scala-xml dependency than scala-compiler does, as long as the versions are binary compatible. (And unless it's too difficult to achieve, I suppose.) Let's discuss further on 7654