sbtinstruments / aiomqtt

The idiomatic asyncio MQTT client, wrapped around paho-mqtt
https://sbtinstruments.github.io/aiomqtt
BSD 3-Clause "New" or "Revised" License
393 stars 71 forks source link

feat: expose paho tls_insecure_set(bool) #234

Closed steersbob closed 11 months ago

steersbob commented 11 months ago

Resolves #227

Adds the tls_insecure kwarg to Client __init__(). If set, the value is forwarded directly to the Paho tls_insecure_set() function.

codecov[bot] commented 11 months ago

Codecov Report

Merging #234 (36a8ce5) into main (33a9d9a) will decrease coverage by 0.4%. The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #234     +/-   ##
=======================================
- Coverage   84.5%   84.1%   -0.4%     
=======================================
  Files          4       4             
  Lines        466     468      +2     
  Branches      86      87      +1     
=======================================
  Hits         394     394             
- Misses        46      47      +1     
- Partials      26      27      +1     
Impacted Files Coverage Δ
aiomqtt/client.py 82.7% <0.0%> (-0.4%) :arrow_down:
frederikaalund commented 11 months ago

Hi Bob, thank you for opening this pull request. :)

LGTM! A good showcase of a nice and self-contained first PR. It does decrease our test coverage but I'll allow it. I'll merge this PR as is.

Thank you for your contribution to asyncio-mqtt. :+1: