sbtinstruments / aiomqtt

The idiomatic asyncio MQTT client, wrapped around paho-mqtt
https://sbtinstruments.github.io/aiomqtt
BSD 3-Clause "New" or "Revised" License
393 stars 71 forks source link

fix: client aenter connect error lock release #245

Closed vvanglro closed 10 months ago

vvanglro commented 10 months ago

fix: #244

codecov[bot] commented 10 months ago

Codecov Report

Merging #245 (1058b6d) into main (40d4f56) will increase coverage by 0.5%. The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #245     +/-   ##
=======================================
+ Coverage   84.1%   84.7%   +0.5%     
=======================================
  Files          4       4             
  Lines        468     472      +4     
  Branches      87      87             
=======================================
+ Hits         394     400      +6     
+ Misses        47      45      -2     
  Partials      27      27             
Files Changed Coverage Δ
aiomqtt/client.py 83.3% <100.0%> (+0.6%) :arrow_up:
vvanglro commented 10 months ago

ci relevant: https://github.com/snok/install-poetry/issues/94

empicano commented 10 months ago

Hi there,

Great that you put work into this, thank you! 😎 I believe the reason that the tests are failing is that the poetry dropped support for Python 3.7 in 1.6.0 rather than the issue you linked. See also your first commit, where all those workflows that use Python 3.7 fail, but not the others.

Python 3.7 reached its end of life, so I think we can drop it anyways. I opened PR #246 to do that.

Your PR looks good to me otherwise 🙂

vvanglro commented 10 months ago

Python 3.7 reached its end of life, so I think we can drop it anyways. I opened PR #246 to do that.

When your PR is merged, I will merge it once.

frederikaalund commented 10 months ago

Looks good to me as well. :+1: I just reviewed #246 as well.

empicano commented 10 months ago

Thanks for another great contribution to aiomqtt, @vvanglro! 💪