Closed vvanglro closed 10 months ago
Merging #245 (1058b6d) into main (40d4f56) will increase coverage by
0.5%
. The diff coverage is100.0%
.
@@ Coverage Diff @@
## main #245 +/- ##
=======================================
+ Coverage 84.1% 84.7% +0.5%
=======================================
Files 4 4
Lines 468 472 +4
Branches 87 87
=======================================
+ Hits 394 400 +6
+ Misses 47 45 -2
Partials 27 27
Files Changed | Coverage Δ | |
---|---|---|
aiomqtt/client.py | 83.3% <100.0%> (+0.6%) |
:arrow_up: |
ci relevant: https://github.com/snok/install-poetry/issues/94
Hi there,
Great that you put work into this, thank you! 😎 I believe the reason that the tests are failing is that the poetry dropped support for Python 3.7 in 1.6.0 rather than the issue you linked. See also your first commit, where all those workflows that use Python 3.7 fail, but not the others.
Python 3.7 reached its end of life, so I think we can drop it anyways. I opened PR #246 to do that.
Your PR looks good to me otherwise 🙂
Python 3.7 reached its end of life, so I think we can drop it anyways. I opened PR #246 to do that.
When your PR is merged, I will merge it once.
Looks good to me as well. :+1: I just reviewed #246 as well.
Thanks for another great contribution to aiomqtt, @vvanglro! 💪
fix: #244