search

sbtinstruments / aiomqtt

The idiomatic asyncio MQTT client, wrapped around paho-mqtt
https://sbtinstruments.github.io/aiomqtt
BSD 3-Clause "New" or "Revised" License
393 stars 71 forks source link

Update Ruff and Mypy, Remove Black #255

Closed JonathanPlasse closed 6 months ago

JonathanPlasse commented 8 months ago

Hi @frederikaalund, @empicano, It has been a while. Ruff finally released its formatter, it is very close to the Black code style but is 30x faster. I also updated Mypy, deprecated VSCode settings, and the check script All commits have a body that explains the changes.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f067cd3) 84.4% compared to head (60e2590) 84.5%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #255 +/- ## ===================================== Coverage 84.4% 84.5% ===================================== Files 4 4 Lines 482 485 +3 Branches 90 91 +1 ===================================== + Hits 407 410 +3 Misses 47 47 Partials 28 28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

empicano commented 6 months ago

Hi Jonathan, I think these changes look great 😊 Are you waiting on something to merge?

JonathanPlasse commented 6 months ago

No, I will merge it tomorrow.