sbtoonz / BackPacks_Remake

1 stars 0 forks source link

[Bug] Items dissapear when placed outside of top-left 2x4 area of the backpack window (Multiplayer issue) #51

Open TheGrayJacket opened 2 years ago

TheGrayJacket commented 2 years ago

Hello,

So I crafted "Fine Backpack" and moved all the items from the old "Rugged Backpack" to the new one.

A few moment later I noticed that some of the items I put inside it were gone. I used commands to recover those items, but it happened again.

I initially thought it was due to the fact I enchanted Fine Backpack (using EpicLoot mod). So I ran several tests in order to verify the source and replicate the bug. Unfortunately (or fortunately, depending on PoV) this wasn't caused by EpicLoot.

This happened without a fault, every time I went to the base I built close to The Altar. That base was built using all kinds of different bits and pieces from all different mods, so I had to move to a separate location in order to try to replicate the bug by placing every modded structure and looking if one of them did wipe half of my backpack. Unfortunately, none of them causes this.

One thing I noticed is that every time this issue happened, I could not open my backpack with SHIFT+E (opening sound played but backpack did not open). I had to move it to another slot in the inventory, then I could open it and when I moved an item to "wrong slot" it got instantly deleted.

At this point, I am waiting for the server admin to come back to test if the issue still persists if we remove "Construction" by MrSerji or "Shipyard" by CookieMilk.

Other possible culprits might be Item and Armor stands, since this base is the only place with them, but I am not sure how that might cause this issue.

I would like to apologize for this vague Bug report. I have been running around trying to find what causes this for more than 2 hours and managed to narrow it down to possible 4 causes listed above.

Also, by "Backpack Window being restricted" I mean that everything other than 2x4 upper-left corner of the Fine Backpack lvl1 is deleted. This can be seen in the screenshots I attached to this issue:

I will write here again if I manage to find what is causing it.

01_full_backpack 02_after_the_bug 03_moving_item_to_bugged_slot A 04_moving_item_to_bugged_slot B jpg bepinex log when backpack locks bepinex log when teleporting to bug location.txt HF8E3j4MVw.txt

TheGrayJacket commented 2 years ago

I just checked if I will get the same problem on Rugged Backpack lvl 4 and this issue only applies (so far) to Fine Backpack lvl 1: rugged_backpack fine_backpack

TheGrayJacket commented 2 years ago

Surprisingly, something unusual happened today. Which is quite troublesome since you might not be able to reproduce this bug.

Rugged Backpack lvl4 works fine for me, BUT does not work correctly for my brother, who is playing with me and hosting the server. He's having the same issue with Rugged Backpack lvl 3 and 4 that I had with Fine Backpack lvl1

Deleted2022 commented 2 years ago

So I've been having exactly the same issues. They've been intermittent and so far I haven't managed to consistently reproduce them, but they're everything described here.

I did not have the "Construction" by MrSerji mod installed and I believe I was experiencing the issue way before Balrond Shipyard even released.

What I did notice is that it happened on a dedicated server when another player was also wearing a backpack. If we went near each other wearing backpacks, one of us wouldn't be able to open their backpack when hitting E. They'd have to unequip and re-equip it.

I also noticed that this was usually when items seemed to disappear if the backpack was full. It seemed like the size was getting reduced to a much smaller one and anything that didn't fit was being removed.

Not sure if it could have been conflicting configs. I can setup a dedicated server to test this on the weekend. I have not noticed it happening in single player though.

TheGrayJacket commented 2 years ago

It's not being caused by "Construction" by MrSerji, but since uninstalling this mod the bug no longer happens in the spot it used to. The only accompanying occurrence is when player experiences lower than average framerates (like location hopping to a new area with lots of object to load in) Another thing is that it is always backpack slots other than top-left 2x4 that are getting wiped. Maybe some config is not being loaded in time and game recognizes only this part of the backpack? Really hard to tell

Deleted2022 commented 2 years ago

@TheGrayJacket Is it only happening when you're in close proximity to another player who is also wearing a backpack?

TheGrayJacket commented 2 years ago

Not really. First time it happened I was quite the far away from him.

Another accompanying occurrence is that backpack... kind of... half de-equips by itself? It's still marked as equipped, but I cannot open it until I re-equip it or move it to a different slot in the inventory.

We were just mining silver by digging around it to one-shot it. The moment it breaks it causes a huge fps spike, so again, might be caused by some sort of overload on the client.

Thing is, my backpack is fine now. It's only my brother's backpack that gets wiped.

TheGrayJacket commented 2 years ago

We tested a bit further and it appears the issue is actually caused by two people having a backpack. Not sure why, but one player will not have any issue with the backpack while the other player might experience some weird things:

  1. When Player A have the backpack open, and player B opens his backpack, Player A backpack will close and enter half-de-equip status (equipped, but can't open)
  2. When Player A have backpack equipped , and Player B does not, Player B can still open backpack (2x4 window opens)
  3. When 2. happens and Player B opens his backpack, everything outside 2x4 is wiped.
Deleted2022 commented 2 years ago

Yeah this matches my experience exactly.

sbtoonz commented 2 years ago

https://github.com/sbtoonz/BackPacks_Remake/discussions/52

4Magma commented 2 years ago

I had a similar situation while playing in solo mode.

possible cause:

sbtoonz commented 2 years ago

I had a similar situation while playing in solo mode.

  • no reaction on shift-e

    • once with overweight, but perhaps only coincidence
    • level 4 was back to size of level 2|3
    • got full size back after recycle 1 level and upgrade
  • item loss (painfully poison and frost potions)

    • emptied my inventory with smarter container mod, but potions should land in the backpack
    • tested via splitting a single potion which also vanished

possible cause:

  • i had armorstands with my old equipment sets and on one of them was the older backpack
  • old backpack is now in a chest for testing

52

sbtoonz commented 2 years ago

https://github.com/sbtoonz/BackPacks_Remake/releases/tag/v0.3.4