sbtourist / Journal.IO

Journal.IO is a zero-dependency, fast and easy-to-use journal storage implementation.
Apache License 2.0
260 stars 39 forks source link

Fix data leaks due to free-flying Journal instances #37

Closed hhoffstaette closed 11 years ago

hhoffstaette commented 11 years ago

As discussed: with these changes all tests reliably & repeatably pass, both in eclipse and maven. Changes to the test superclass were minimal and while I'm not super-happy with the duplication of test setup/teardown logic it is symmetric, allows per-test isolation with minimum effort and works. IMHO it would be less fragile to only create the directory & do cleanup in the superclass, and always have each test class create/open/close the per-test Journal it needs individually.

sbtourist commented 11 years ago

In the end, I applied some of the changes here, without directly merging. Hope things still work for you, otherwise feel free to reopen this.

hhoffstaette commented 11 years ago

I just confirmed that everything still works with 1.3 final.

sbtourist commented 11 years ago

Thanks much!