search

sbugert / react-native-admob

A react-native component for Google AdMob banners
BSD 2-Clause "Simplified" License
1.13k stars 531 forks source link

support Native Ads #113

Open escolhatecnologia opened 7 years ago

escolhatecnologia commented 7 years ago

Any support for Native Ads?

https://firebase.google.com/docs/admob/android/native

alvaromb commented 7 years ago

PRs are welcome.

ghost commented 7 years ago

would be nice to have support for
Native Ads Express

https://firebase.google.com/docs/admob/android/native-express

ghost commented 7 years ago

Any update?

alvaromb commented 7 years ago

I don't see any PR regarding this feature and I don't have time to work on that right now.

How do you feel about sending a PR, @userTestGit? :)

ghost commented 7 years ago

@alvaromb would be nice, but I don't have time to work on that right now too.

Mifayo commented 7 years ago

that would be awesome :( we need native ads in react-native-admob

alvaromb commented 7 years ago

I can perform reviews, but I don't have time to develop this feature.

Please send us a PR :)

ghost commented 7 years ago

@alvaromb with native ads i will 100% sure that is my admob ID and not yours ;)

xing-zheng commented 7 years ago

It should be great, native ads

wkrause13 commented 7 years ago

I have native express ads working in RN 0.45 using a combination of PR #147 and PR #127. For anyone really needing this feature, it's not too hard to fork and implement from the pull requests. You can reference my fork, but I can't guarantee I won't do silly things on the master branch, so I wouldn't recommend pulling from it directly in your package.json

If you implement this, and you don't see the ads, there are two common reasons why you might not see anything.

  1. You just created the ad template. It can take a little time between initial creation and the adUnitID being valid.
  2. The container isn't big enough to render the ad type you requested. Make sure your height and width props are sufficiently large for the range of supported values for the given native express template type.

I'm not 100% certain the testID="EMULATOR" is working as intended, so be careful to make sure you're getting test ads, lest you incur the wrath of Google. A safe alternative is to find an adUnitID that will always serve test ads. There are a few test adUnitID for different template sizes and platforms, which you should be able to find in their docs or example admob apps referenced in the sdk docs.

@alvaromb, thanks for your work on this library so far! If you get a moment in the next couple of weeks, would you be willing to review the pull requests?

jbolter commented 6 years ago

We are looking into native ads as well so getting these PRs merged in would be great. In the meantime we will look at creating our own fork with the PRs merged together. Thanks @wkrause13 and @alvaromb!

yassy000 commented 6 years ago

Hello, Anyone try to integrate NativeAdvancedAds? I afraid native express is going to deprecated.

moduval commented 6 years ago

Is there any plan on adding this feature on V2 ?